chore: Convert Standard to eslint-config-standard #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
changed the title
heiskr
reviewed
Nov 16, 2020
| @@ -146,13 +150,6 @@ | |||
| "node": "12 - 14" | |||
| }, | |||
| "repository": "https://github.com/github/docs", | |||
| "standard": { | |||
There was a problem hiding this comment.
I'm curious about thoughts on including the eslint config and ignore in package.json instead of as separate files.
There was a problem hiding this comment.
I believe the separate ignore file usually has better performance, but I've not looked at using the inline config in package.json before
heiskr
approved these changes
Nov 16, 2020
|
@nschonni thanks for creating this! Can you resolve the conflicts 🙏🏿 |
nschonni
force-pushed
the
standard-to-eslint-config
branch
from
7334057
to
591bff9
Compare
- .filter must return a boolean value - .map replaced with forEach when the value isn't used
nschonni
force-pushed
the
standard-to-eslint-config
branch
from
591bff9
to
795a74c
Compare
|
@chiedo done! |
|
Just want one more review on this one! @JasonEtco can you please review! |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
This was referenced Aug 18, 2021
This was referenced Aug 18, 2021
This was referenced Sep 23, 2022
This was referenced Sep 27, 2022
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Standard is a wrapper of opionated ESLint rules. By using the direct ESLint config, there is better integration with IDEs for showing ESLint errors while maintaining the existing style preference. Also can drop some of the JSX related dependencies that are bundled as part of the larger
standardpackage.What's being changed:
standardpackage and replace with the ESLint packages forstandardCheck off the following: